New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adaptive Denoising #1066
Adaptive Denoising #1066
Conversation
…ns_block functionality. Plus minor changes
@Garyfallidis Please have a look at this. |
OUTPUT: | ||
y - array x will be shifed by m samples down | ||
along dimension d | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @riddhishb. Please correct docstring to fit the style of our other docstrings.
block_radius=1, | ||
rician=True) | ||
|
||
# Now perform the adaptive soft coefficient matching |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this inline comment
Changes Unknown when pulling c3df90d on riddhishb:adap_denoise into * on nipy:master*. |
Changes Unknown when pulling c3df90d on riddhishb:adap_denoise into * on nipy:master*. |
t = time() | ||
|
||
""" | ||
The ``ascm`` function takes two denoised inputs, one more smooth than the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First sentence has repeated information.
Changes Unknown when pulling 05dbed8 on riddhishb:adap_denoise into * on nipy:master*. |
Changes Unknown when pulling 05dbed8 on riddhishb:adap_denoise into * on nipy:master*. |
The adaptive soft coefficient matching (ASCM) as described in [Coupe11]_ is a | ||
improved extension of non-local means (NLMEANS) denoising. ASCM gives a better | ||
denoised images from two standard non-local means denoised versions of the | ||
original data with different degrees sharp feature preserved. Here, one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace this with '... original data with different degrees of sharpness. Here, one... '
Changes Unknown when pulling 13da3b9 on riddhishb:adap_denoise into * on nipy:master*. |
Changes Unknown when pulling 13da3b9 on riddhishb:adap_denoise into * on nipy:master*. |
I haven't any further comments on the documentation - for me this can be merged! Please let me know asap if anyone have any comments to this PR. We are planning to merge this at the end of this day! |
This branch is for adaptive denoising, currently includes
for adding a blockwise averaging approach in nlmeans
Adaptive soft coefficient matching based denoising
I have also added the keyword to toggle between current voxelwise implementation of nlmeans and the proposed blockwise one.
I am yet to add tests and some examples.